> > --- a/drivers/acpi/nfit/core.c > > +++ b/drivers/acpi/nfit/core.c > > @@ -1031,7 +1031,7 @@ static ssize_t scrub_store(struct device *dev, > > if (nd_desc) { > > struct acpi_nfit_desc *acpi_desc = to_acpi_desc(nd_desc); > > > > - rc = acpi_nfit_ars_rescan(acpi_desc); > > + rc = acpi_nfit_ars_rescan(acpi_desc, 0); > > } > > device_unlock(dev); > > if (rc) > > @@ -2057,6 +2057,10 @@ static int ars_start(struct acpi_nfit_desc > *acpi_desc, struct nfit_spa *nfit_spa > > ars_start.type = ND_ARS_VOLATILE; > > else > > return -ENOTTY; > > + if (nfit_spa->ars_prev_data) { > > + ars_start.flags |= ND_ARS_RETURN_PREV_DATA; > > + nfit_spa->ars_prev_data = 0; > > + } > > I'd rather you plumb a new 'flags' parameter all the way through from > acpi_nfit_ars_rescan() to ars_start() rather than carrying this as a > property of nfit_spa. Yes, I wanted to carry 'flags' all the way, but since acpi_nfit_ars_rescan() calls acpi_nfit_scrub() via acpi_desc->work, all info needs to be marshalled into struct acpi_nfit_desc. Using nfit_spa allows a request to be carried as per-spa basis... Thanks, -Toshi ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f