Thanks for this. I think it's going in the right direction, but one comment below. On Thu, Jun 8, 2017 at 11:36 AM, Toshi Kani <toshi.kani@xxxxxxx> wrote: > ACPI 6.2 defines in section 9.20.7.2 that the OSPM may call a Start > ARS with Flags Bit [1] set upon receiving the 0x81 notification. > > Upon receiving the notification, the OSPM may decide to issue > a Start ARS with Flags Bit [1] set to prepare for the retrieval > of existing records and issue the Query ARS Status function to > retrieve the records. > > Add support to call a Start ARS from acpi_nfit_uc_error_notify() > with ND_ARS_RETURN_PREV_DATA set when HW_ERROR_SCRUB_ON is not set. > > Link: http://www.uefi.org/sites/default/files/resources/ACPI_6_2.pdf > Signed-off-by: Toshi Kani <toshi.kani@xxxxxxx> > Cc: Dan Williams <dan.j.williams@xxxxxxxxx> > Cc: Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> > Cc: Vishal Verma <vishal.l.verma@xxxxxxxxx> > Cc: Linda Knippers <linda.knippers@xxxxxxx> > --- > drivers/acpi/nfit/core.c | 14 +++++++++++--- > drivers/acpi/nfit/mce.c | 2 +- > drivers/acpi/nfit/nfit.h | 3 ++- > include/uapi/linux/ndctl.h | 1 + > 4 files changed, 15 insertions(+), 5 deletions(-) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index cc22778..d820d72 100644 > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -1031,7 +1031,7 @@ static ssize_t scrub_store(struct device *dev, > if (nd_desc) { > struct acpi_nfit_desc *acpi_desc = to_acpi_desc(nd_desc); > > - rc = acpi_nfit_ars_rescan(acpi_desc); > + rc = acpi_nfit_ars_rescan(acpi_desc, 0); > } > device_unlock(dev); > if (rc) > @@ -2057,6 +2057,10 @@ static int ars_start(struct acpi_nfit_desc *acpi_desc, struct nfit_spa *nfit_spa > ars_start.type = ND_ARS_VOLATILE; > else > return -ENOTTY; > + if (nfit_spa->ars_prev_data) { > + ars_start.flags |= ND_ARS_RETURN_PREV_DATA; > + nfit_spa->ars_prev_data = 0; > + } I'd rather you plumb a new 'flags' parameter all the way through from acpi_nfit_ars_rescan() to ars_start() rather than carrying this as a property of nfit_spa. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
