On Friday, March 31, 2017 11:57:47 AM Hans de Goede wrote: > Hi, Hi, [cut] > > > > Anyway, I'd prefer blacklists in the battery and ac drivers to be honest. > > As I explained in my reply to the discussion around the first patch that > is somewhat hard to do and requires encoding knowledge in those drivers > which really does not belong there: > > "The problem is that Intel re-uses HIDs between generations and > for the Whiskey Cove PMIC we want to not use the ACPI battery > and ac drivers on Cherry Trail (where they are known to be > broken) but things are different on Apollo Lake. Yet both > use the same HID for their companion Whiskey Cove PMIC even > though they are 2 completely different revisions of the PMIC > (e.g. one uses i2c the other does not). > > The 2 native drivers have code to detect which revision they > are dealing with and exit with -ENODEV if it is not the > revision they were written for, but this means that simple > HID blacklisting will not work. So IMHO the decision to > unregister the ACPI battery / ac interface really belongs > in the native driver as that has all the nitty gritty detail > needed to make that decision." Do the native drivers bind to platform devices? Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
