On Fri, Mar 31, 2017 at 11:08 AM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > Hi, > > On 31-03-17 11:05, Rafael J. Wysocki wrote: >> >> On Fri, Mar 31, 2017 at 11:01 AM, Hans de Goede <hdegoede@xxxxxxxxxx> >> wrote: >> >> [cut] >> >>>>> --- a/drivers/power/supply/axp288_fuel_gauge.c >>>>> +++ b/drivers/power/supply/axp288_fuel_gauge.c >>>>> @@ -26,6 +26,7 @@ >>>>> #include <linux/mfd/axp20x.h> >>>>> #include <linux/platform_device.h> >>>>> #include <linux/power_supply.h> >>>>> +#include <linux/power/acpi.h> >>>>> #include <linux/iio/consumer.h> >>>>> #include <linux/debugfs.h> >>>>> #include <linux/seq_file.h> >>>>> @@ -754,6 +755,8 @@ static int axp288_fuel_gauge_probe(struct >>>>> platform_device *pdev) >>>>> return ret; >>>>> } >>>>> >>>>> + acpi_battery_unregister(); >>>>> + >>>> >>>> >>>> >>>> What if the ACPI battery driver is loaded after this has been called >>>> already? >>> >>> >>> >>> The module exports that symbol so it must be loaded already. >> >> >> But then it may be unloaded manually and loaded again, may it not? > > > Only if you first unload axp288_fuel_gauge.ko otherwise it will > have a refcount > 0. OK Anyway, I'd prefer blacklists in the battery and ac drivers to be honest. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
