Em Fri, 07 Mar 2014 01:21:54 -0500 "Chen, Gong" <gong.chen@xxxxxxxxxxxxxxx> escreveu: > On Thu, Mar 06, 2014 at 12:39:15PM -0300, Mauro Carvalho Chehab wrote: > > Date: Thu, 06 Mar 2014 12:39:15 -0300 > > From: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx> > > To: Borislav Petkov <bp@xxxxxxxxx> > > Cc: "Chen, Gong" <gong.chen@xxxxxxxxxxxxxxx>, tony.luck@xxxxxxxxx, > > arozansk@xxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH 1/2] trace, RAS: Add basic RAS trace event > > X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; x86_64-redhat-linux-gnu) > > > > Em Thu, 06 Mar 2014 16:26:33 +0100 > > Borislav Petkov <bp@xxxxxxxxx> escreveu: > > > > > On Thu, Mar 06, 2014 at 10:06:53AM -0300, Mauro Carvalho Chehab wrote: > > > > For example PCIe and memory errors are not x86-specific. Also, as ACPI > > > > may also be used on ARM, we may also start to have APEI errors there: > > > > https://lwn.net/Articles/574439/ > > > > https://wiki.linaro.org/LEG/Engineering/Kernel/ACPI > > > > > > > > So, better to think on that on a long term. > > > > > > kernel/ras/ could also be used in that case but I guess drivers/ras/ is > > > fine too. > > > > Both work for me, although drivers/ras seems more adequate, IMHO, > > as I expect that we'll have there both subsystem code and drivers. > > > OK, I will move this trace stub to drivers/ras in next version. Thanks! > BTW, any other comments for 2nd patch? I thought Mauro will > have some comments for that patch. :-) Well, the comment is the same: I still think that the better would be to map this via EDAC, in order to allow userspace to associate the DIMM labels with the DIMMs that would be reported, as the association of card, module, rank number, valid device into the corresponding DIMM slot, as marked at the board's silkscreen is not trivial. If you're not willing to do that, the better would then to add such association logic inside the rasdaemon. Patches are welcomed. Regards, Mauro
Attachment:
signature.asc
Description: PGP signature