> > > Sort package only after null/bad elements have been removed. This is the bug. Lv, this should probably be something like: > > > Fixes a problem where the _CST sort was performed too early. This change sorts the package only after null/bad elements have been removed. > -----Original Message----- > From: Rafael J. Wysocki [mailto:rjw@xxxxxxx] > Sent: Tuesday, June 18, 2013 2:50 PM > To: Moore, Robert > Cc: Len Brown; Zheng, Lv; Wysocki, Rafael J; Brown, Len; linux acpi > Subject: Re: [PATCH 15/16] ACPICA: _CST repair: Handle null package > entries > > On Tuesday, June 18, 2013 06:52:12 PM Moore, Robert wrote: > > This change fixes a bug in the original _CST repair code. > > Well, in that case the changelog should explain what the bug is/was. > > Thanks, > Rafael > > > > > -----Original Message----- > > > From: lenb417@xxxxxxxxx [mailto:lenb417@xxxxxxxxx] On Behalf Of Len > > > Brown > > > Sent: Wednesday, June 12, 2013 11:00 AM > > > To: Zheng, Lv > > > Cc: Wysocki, Rafael J; Moore, Robert; Brown, Len; linux acpi > > > Subject: Re: [PATCH 15/16] ACPICA: _CST repair: Handle null package > > > entries > > > > > > On Fri, Jun 7, 2013 at 9:01 PM, Lv Zheng <lv.zheng@xxxxxxxxx> wrote: > > > > Sort package only after null/bad elements have been removed. > > > > Lv Zheng. > > > > > > > > > again, please explain WHY. > > > > > > Every line of change to the kernel adds risk. > > > I see no justification in this commit message why any risk should be > > > added to the kernel. > > > > > > Nacked-by: Len Brown <len.brown@xxxxxxxxx> > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-acpi" > > in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo > > info at http://vger.kernel.org/majordomo-info.html > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
