RE: [PATCH 07/16] ACPICA: New: Portable acpidump utility (get system ACPI tables)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sorry, I don't think the Linux version has been completed in version 20130517 -- so perhaps you should ignore this patch after all, unless you want to simply establish the infrastructure for the final Linux version. The Linux-specific code is completed and will be part of the June release.

However, we can still discuss the future of the changelog, etc. We seem to have an overall problem where the ACPICA commit log is "generic", but I'm seeing here a request to make the actual Linux patches more specific to Linux.

As far as acpica and acpidump is concerned, I put specific generation instructions in the reference manual...

Of course, the details for any individual operating system may be different (especially file locations), so I have to make the acpica changelog somewhat generic.


Here is the actual acpica changelog text concerning acpidump, for version 20130517:

2) iASL Compiler/Disassembler and Tools:

New utility: Implemented an easily portable version of the acpidump 
utility to extract ACPI tables from the system (or a file) in an ASCII hex 
dump format. The top-level code implements the various command line 
options, file I/O, and table dump routines. To port to a new host, only 
three functions need to be implemented to get tables -- since this 
functionality is OS-dependent. See the tools/acpidump/apmain.c module and 
the ACPICA reference for porting instructions. ACPICA BZ 859. Notes:
1) The Windows version obtains the ACPI tables from the Registry.
2) The Linux version is under development.
3) Other hosts - If an OS-dependent module is submitted, it will be 
distributed with ACPICA.






> -----Original Message-----
> From: Rafael J. Wysocki [mailto:rjw@xxxxxxx]
> Sent: Tuesday, June 18, 2013 2:41 PM
> To: Moore, Robert
> Cc: Len Brown; Zheng, Lv; Wysocki, Rafael J; Brown, Len; linux acpi
> Subject: Re: [PATCH 07/16] ACPICA: New: Portable acpidump utility (get
> system ACPI tables)
> 
> On Tuesday, June 18, 2013 09:21:22 PM Moore, Robert wrote:
> > It would be a similar generation to the iASL compiler or the acpixtract
> utility.
> 
> Well, so why don't we write in the changelog: "This change allows the user
> to build the portable acpidump utility by executing the following command:
> ..."
> and so on?
> 
> Rafael
> 
> 
> > > -----Original Message-----
> > > From: Rafael J. Wysocki [mailto:rjw@xxxxxxx]
> > > Sent: Tuesday, June 18, 2013 2:06 PM
> > > To: Moore, Robert
> > > Cc: Len Brown; Zheng, Lv; Wysocki, Rafael J; Brown, Len; linux acpi
> > > Subject: Re: [PATCH 07/16] ACPICA: New: Portable acpidump utility
> > > (get system ACPI tables)
> > >
> > > On Tuesday, June 18, 2013 06:53:42 PM Moore, Robert wrote:
> > > > Please don't drop this if it is indeed the acpidump utility.
> > >
> > > Well, that's unclear to me to be honest. :-)
> > >
> > > > This utility is now a part of ACPICA and should replace the
> > > > existing
> > > utility.
> > >
> > > OK, but we need to tell the users how to build it.
> > >
> > > Thanks,
> > > Rafael
> > >
> > >
> > > > > -----Original Message-----
> > > > > From: Rafael J. Wysocki [mailto:rjw@xxxxxxx]
> > > > > Sent: Saturday, June 15, 2013 4:10 PM
> > > > > To: Len Brown
> > > > > Cc: Zheng, Lv; Wysocki, Rafael J; Moore, Robert; Brown, Len;
> > > > > linux acpi
> > > > > Subject: Re: [PATCH 07/16] ACPICA: New: Portable acpidump
> > > > > utility (get system ACPI tables)
> > > > >
> > > > > On Wednesday, June 12, 2013 01:07:50 PM Len Brown wrote:
> > > > > > > This utility dumps the system ACPI tables in an ascii format
> > > > > > > suitable for extraction via the acpixtract utility.
> > > > > >
> > > > > > This commit message does not match the contents of the patch,
> > > > > > or explain how this patch is related (or not) to the acpidump
> > > > > > utility already in the kernel tree under
> > > > > > tools/power/acpi/acpidump/
> > > > > >
> > > > > > Naked-by: Len Brown <len.brown@xxxxxxxxx>
> > > > >
> > > > > Well, I was on the verge of dropping this one before, so dropped
> now.
> > > > >
> > > > > Thanks,
> > > > > Rafael
> > > > >
> > > > >
> > > > > --
> > > > > I speak only for myself.
> > > > > Rafael J. Wysocki, Intel Open Source Technology Center.
> > > >
> > > --
> > > I speak only for myself.
> > > Rafael J. Wysocki, Intel Open Source Technology Center.
> >
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f





[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux