Fixes these possible problems. I think we've actually seen at least one of these, not sure where/when: * DESCRIPTION: Repair for the _CST object: * 1. Sort the list ascending by C state type * 2. Ensure type cannot be zero * 3. A sub-package count of zero means _CST is meaningless * 4. Count must match the number of C state sub-packages > -----Original Message----- > From: Rafael J. Wysocki [mailto:rjw@xxxxxxx] > Sent: Tuesday, June 18, 2013 2:49 PM > To: Moore, Robert > Cc: Len Brown; Zheng, Lv; Wysocki, Rafael J; Brown, Len; linux acpi > Subject: Re: [PATCH 14/16] ACPICA: Add several repairs for _CST predefined > name > > On Tuesday, June 18, 2013 06:51:45 PM Moore, Robert wrote: > > Correct, additional _CST sanity checks and repairs. > > OK, and what AML breakage does it help against, in particular? > > Rafael > > > > > -----Original Message----- > > > From: lenb417@xxxxxxxxx [mailto:lenb417@xxxxxxxxx] On Behalf Of Len > > > Brown > > > Sent: Wednesday, June 12, 2013 10:59 AM > > > To: Zheng, Lv > > > Cc: Wysocki, Rafael J; Moore, Robert; Brown, Len; linux acpi > > > Subject: Re: [PATCH 14/16] ACPICA: Add several repairs for _CST > > > predefined name > > > > > > On Fri, Jun 7, 2013 at 9:01 PM, Lv Zheng <lv.zheng@xxxxxxxxx> wrote: > > > > Sort list based on the C-state, remove invalid/zero entries. > > > > ACPICA BZ 890. Lv Zheng. > > > > > > The commit message should not just say what the code does, it should > > > more importantly answer WHY the change was made, and why anybody > > > should care about the patch. > > > > > > I think the answer here is that we are adding _CST sanity checking > > > -- presumably to deal with buggy AML? > > > > > > What will we see happen after this patch that we did not see before > it? > > > > > > Nacked-by: Len Brown <len.brown@xxxxxxxxx> > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-acpi" > > in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo > > info at http://vger.kernel.org/majordomo-info.html > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
