Zhao Yakui wrote:
On Sun, 2008-11-09 at 23:27 +0800, Alexey Starikovskiy wrote:
Yakui,
Please take a look at the subject of the thread -- notice words "fatal"
and "(EC transaction is done in interrupt context)".
Looks horrible, isn't it? Now we begin to get into details, and it appears
that it is not fatal, introduced 3.5 years ago, and has nothing to do with
interrupt context transaction patch.
So, the whole point of your message is to spread FUD about "fast
transaction" patch,
and show how great you are. I would guess that you've failed in
achieving both goals.
I won't argue with you about this issue.
Good.
In your patch the program logic states that the EC transaction is
already finished. But in fact the EC transaction is not really finished.
They are inconsistent. Why can't call this a fatal logic error?
The more important is that the failure in EC transaction can't be
detected in time.
Why can't call this a fatal logic error?
Here is Merriam-Webster' definition of "fatal", look at use case number
4, which
is closest to your use of it:
<a href="http://www.merriam-webster.com/dictionary/fatal";>fatal</a>
As we lived with the problem you decribe all these years, it can not be
described as
"causing failure/death", thus it can not be called "fatal".
If this is not a fatal logic error, what can be called fatal? Like that
Several commits are reverted each other as the following three commits.
a.7c010de7506954e973abfab5c5999c5a97f7a73e
b.4c611060660f0de3e9b8f02df207312bc6f5c331
c.f9319f903f898dd4b15dbc386499725ce6c59776
If I had all these machines sitting on my desk side-by-side, I may have
fixed them with one patch,
otherwise one need to make rounds. Do you know any other solution?
If you still reply the subject so impolitely, Don't blame that I will
forward the similar error to wider range.
You send false or bended statements not for the first time, do you
expect any other treatment?
You certainly could do whatever you want, but prepare for others to
include you in ignore/spam list.
Regards,
Alex.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
