On Fri, 2008-11-07 at 12:39 +0800, Len Brown wrote: > From: Alexey Starikovskiy <astarikovskiy@xxxxxxx> > > breakage introduced by following patch > commit 27663c5855b10af9ec67bc7dfba001426ba21222 > Author: Matthew Wilcox <willy@xxxxxxxxxxxxxxx> > Date: Fri Oct 10 02:22:59 2008 -0400 > > acpi_evaluate_integer() does not clear passed variable if > there is an error at evaluation. > So if we ignore error, we must supply initialized variable. > > References: http://bugzilla.kernel.org/show_bug.cgi?id=11917 > http://bugzilla.kernel.org/show_bug.cgi?id=11896 The bug references for 11896 should be deleted. The bug for 11896 can't be resolved by this patch. Thanks. > > Signed-off-by: Alexey Starikovskiy <astarikovskiy@xxxxxxx> > Tested-by: Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx> > Signed-off-by: Len Brown <len.brown@xxxxxxxxx> > --- > drivers/acpi/ec.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > index ef42316..523ac5b 100644 > --- a/drivers/acpi/ec.c > +++ b/drivers/acpi/ec.c > @@ -736,7 +736,7 @@ static acpi_status > ec_parse_device(acpi_handle handle, u32 Level, void *context, void **retval) > { > acpi_status status; > - unsigned long long tmp; > + unsigned long long tmp = 0; > > struct acpi_ec *ec = context; > status = acpi_walk_resources(handle, METHOD_NAME__CRS, > @@ -751,6 +751,7 @@ ec_parse_device(acpi_handle handle, u32 Level, void *context, void **retval) > return status; > ec->gpe = tmp; > /* Use the global lock for all EC transactions? */ > + tmp = 0; > acpi_evaluate_integer(handle, "_GLK", NULL, &tmp); > ec->global_lock = tmp; > ec->handle = handle; -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
