2008/8/1 Zhao Yakui <yakui.zhao@xxxxxxxxx>: > On Thu, 2008-07-31 at 23:13 +0400, Alexey Starikovskiy wrote: >> NAK. >> >> As already mentioned, there is no point to put this workaround in ec.c. >> Instead, it should be placed into acpi_register_operation_region, or may >> be even >> higher (like a flag to ignore errors during execution of the method). > Maybe what your said is right. The generic method about ignoring the > error during the execution of the method is very good. But it will > become more complicated. Maybe it is too aggressive and will have other > side effect that we can't know. > > As the acpi_install_address_space_handler is realized in ACPICA and > called by other drivers, it is not appropriate to ignore the error in > the generic ACPICA function. At the same time this error is related with > EC device, maybe it is more appropriate that EC driver determines > whether OS continues to initialize EC device. > > IMO this workaround patch can fix the issue that is related with the EC > _REG method(For example: bug 8953, 10237). At the same time this will > have no effect on the other systems. > > best regards. > Yakui I also support these arguments. The supposed method will complicate the whole process and take more time to be realised. For now this patch has effekt only on relatively small number of machines that are related to bugs 8953 and 10237. Otherwise, it won't affect other systems. So I don't see any obstacles to putting this in the mainstream. --joshua -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
