On Thu, 2008-07-31 at 23:13 +0400, Alexey Starikovskiy wrote: > NAK. > > As already mentioned, there is no point to put this workaround in ec.c. > Instead, it should be placed into acpi_register_operation_region, or may > be even > higher (like a flag to ignore errors during execution of the method). Maybe what your said is right. The generic method about ignoring the error during the execution of the method is very good. But it will become more complicated. Maybe it is too aggressive and will have other side effect that we can't know. As the acpi_install_address_space_handler is realized in ACPICA and called by other drivers, it is not appropriate to ignore the error in the generic ACPICA function. At the same time this error is related with EC device, maybe it is more appropriate that EC driver determines whether OS continues to initialize EC device. IMO this workaround patch can fix the issue that is related with the EC _REG method(For example: bug 8953, 10237). At the same time this will have no effect on the other systems. best regards. Yakui > Regards, > Alex. > > Zhao Yakui wrote: > > On Wed, 2008-07-30 at 19:11 -0700, Moore, Robert wrote: > > > >> Looking at this patch, I see that it solves a very specific case, namely > >> the AE_NOT_FOUND exception. However, this is just one of many exceptions > >> that we may want to ignore. In fact, I wonder if in the general case we > >> should just ignore all exceptions from _REG methods, other than printing > >> some kind of message. > >> > > Yes. This patch only solves the specific case. For example: in the bug > > 8953, 10237. > > > > But if all the exceptions from the _REG methods are ignored, it will be > > too aggressive. Maybe some potential problems will be hidden. We had > > better wait for that more people complain the similar bugs. > > > > Thanks. > > > > > >> Bob > >> > >> > >> > >>> -----Original Message----- > >>> From: linux-acpi-owner@xxxxxxxxxxxxxxx [mailto:linux-acpi- > >>> owner@xxxxxxxxxxxxxxx] On Behalf Of Joshua C. > >>> Sent: Wednesday, July 30, 2008 7:03 PM > >>> To: linux-acpi@xxxxxxxxxxxxxxx > >>> Subject: Re: [PATCH] ACPI: Ignore AE_NOT_FOUND error of EC _REG method > >>> > >> and > >> > >>> continue to initialize EC > >>> > >>> On Mon, Jul 28, 2008 at 14:59:26AM +0800, Andi Kleen wrote: > >>> > >>>>> Subject:ACPI: Ignore AE_NOT_FOUND error of EC _REG method and > >>>>> > >> continue > >> > >>> to initialize EC > >>> > >>>>> From: Zhao Yakui <yakui.zhao@xxxxxxxxx> > >>>>> > >>>> Thanks. Queued for test. How urgent is this? Do we need to consider it > >>>> for .27? > >>>> > >>>> -Andi > >>>> > >>> It will be great if you can put this in .27. > >>> > >>> --joshua > >>> -- > >>> To unsubscribe from this list: send the line "unsubscribe linux-acpi" > >>> > >> in > >> > >>> the body of a message to majordomo@xxxxxxxxxxxxxxx > >>> More majordomo info at http://vger.kernel.org/majordomo-info.html > >>> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > >> the body of a message to majordomo@xxxxxxxxxxxxxxx > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
