Re: [PATCH] ACPI: Ignore AE_NOT_FOUND error of EC _REG method and continue to initialize EC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



NAK.

As already mentioned, there is no point to put this workaround in ec.c.
Instead, it should be placed into acpi_register_operation_region, or may be even
higher (like a flag to ignore errors during execution of the method).

Regards,
Alex.

Zhao Yakui wrote:
On Wed, 2008-07-30 at 19:11 -0700, Moore, Robert wrote:
Looking at this patch, I see that it solves a very specific case, namely
the AE_NOT_FOUND exception. However, this is just one of many exceptions
that we may want to ignore. In fact, I wonder if in the general case we
should just ignore all exceptions from _REG methods, other than printing
some kind of message.
Yes.  This patch only solves the specific case. For example: in the bug
8953, 10237.

But if all the exceptions from the _REG methods are ignored, it will be
too aggressive. Maybe some potential problems will be hidden. We had
better wait for that more people complain the similar bugs.

Thanks.

Bob


-----Original Message-----
From: linux-acpi-owner@xxxxxxxxxxxxxxx [mailto:linux-acpi-
owner@xxxxxxxxxxxxxxx] On Behalf Of Joshua C.
Sent: Wednesday, July 30, 2008 7:03 PM
To: linux-acpi@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] ACPI: Ignore AE_NOT_FOUND error of EC _REG method
and
continue to initialize EC

On Mon, Jul 28, 2008 at 14:59:26AM +0800, Andi Kleen wrote:
Subject:ACPI: Ignore AE_NOT_FOUND error of EC _REG method and
continue
to initialize EC
From: Zhao Yakui <yakui.zhao@xxxxxxxxx>
Thanks. Queued for test. How urgent is this? Do we need to consider it
for .27?

-Andi
It will be great if you can put this in .27.

--joshua
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi"
in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux