On Tue, Jun 18, 2024 at 07:58:45PM +0800, Youwan Wang wrote: > Defining `amba_dummy_clk` as static is meaningless. > > The amba_register_dummy_clk() function is static and > is called during initialization. I think 'amba_dummy_clk' > should be NULL each time when initializing > Also I missed to read the commit message, please update it as follows: " ACPI / amba: Drop unnecessary check for registered amba_dummy_clk amba_register_dummy_clk() is called only once from acpi_amba_init() and acpi_amba_init() itself is called once during the initialisation. amba_dummy_clk cann't be initialised before this in any other code path and hence the check for already registered amba_dummy_clk is not necessary. Drop the same. " Also few other things to note: 1. You missed to add my Acked-by which I gave to your v2 2. This is v3 and new reviewers of this patch have absolutely no idea what got changed from v1->v2->v3. It is always good to add change log across versions 3. I asked you to add ARM64 maintainers as we would request them to pick this up via ARM64 tree. Catalin Marinas <catalin.marinas@xxxxxxx Will Deacon <will@xxxxxxxxxx> -- Regards, Sudeep
