Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 14, 2024 at 02:09:38PM +0000, Jonathan Cameron wrote:
> On Tue, 13 Feb 2024 10:22:45 +0000
> Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> wrote:
> 
> > On Mon, 12 Feb 2024 12:58:03 +0000
> > Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
> > 
> > > On Mon, Feb 12, 2024 at 02:46:49PM +0200, Andy Shevchenko wrote:  
> > > > On Mon, Feb 12, 2024 at 12:36:46PM +0000, Sakari Ailus wrote:    
> > > > > On Mon, Feb 12, 2024 at 11:42:06AM +0000, Jonathan Cameron wrote:    
> > > > 
> > > > ...
> > > >     
> > > > > Hmm. In that case I'd rather make fwnode_handle_put() and similar trivial
> > > > > functions macros.    
> > > > 
> > > > This will kill the type-checking opportunity, so I'm against this move.    
> > > 
> > > Then it could be made static inline and moved to the header. I suppose for
> > > modern compilers there should be no difference in between the two
> > > optimisation-wise.
> > >   
> > 
> > Sure - will be a bit fiddly as this is only worth doing if we drop
> > the internal check that buried several macros deep.
> 
> Not enough coffee yesterday. We can just move the the existing
> fwnode_handle_put() to property.h as that includes fwnode.h has
> all the definitions in it which we need to be able to see.
> 
> I think that should be uncontroversial?

I agree.

-- 
Sakari Ailus




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux