Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Date: Mon, 12 Feb 2024 14:05:30 +0200
Cc: Jonathan Cameron <jic23@xxxxxxxxxx>, linux-iio@xxxxxxxxxxxxxxx, "Rafael J . Wysocki" <rafael@xxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, linux-acpi@xxxxxxxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Daniel Scally <djrscally@xxxxxxxxx>, Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>, Julia Lawall <Julia.Lawall@xxxxxxxx>, Nuno Sá <nuno.sa@xxxxxxxxxx>, Cosmin Tanislav <cosmin.tanislav@xxxxxxxxxx>, Mihail Chindris <mihail.chindris@xxxxxxxxxx>, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>, Tomislav Denis <tomislav.denis@xxxxxxx>, Marek Vasut <marex@xxxxxxx>, Olivier Moysan <olivier.moysan@xxxxxxxxxxx>, Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>, Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>, Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>, Marius Cristea <marius.cristea@xxxxxxxxxxxxx>, Ibrahim Tilki <Ibrahim.Tilki@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
In-reply-to: <Zcnbk6_9BU_trU9P@kekkonen.localdomain>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20240211192540.340682-1-jic23@kernel.org> <20240211192540.340682-2-jic23@kernel.org> <Zcnbk6_9BU_trU9P@kekkonen.localdomain>

On Mon, Feb 12, 2024 at 08:49:23AM +0000, Sakari Ailus wrote:
> On Sun, Feb 11, 2024 at 07:25:27PM +0000, Jonathan Cameron wrote:

...

> > +DEFINE_FREE(fwnode_handle, struct fwnode_handle *,
> > +	    if (!IS_ERR_OR_NULL(_T)) fwnode_handle_put(_T))
> 
> fwnode_handle_put() can be safely called on NULL or error pointer fwnode

Yes.

> so you can remove the check.

No. (Technically "yes", but better "no".)

This has been discussed a lot, including the LWN wrap-up about the cleanup.h.

-- 
With Best Regards,
Andy Shevchenko

References:
- [PATCH v2 00/14] device property / IIO: Use cleanup.h magic for fwnode_handle_put() handling.
  - From: Jonathan Cameron
- [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
  - From: Jonathan Cameron
- Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
  - From: Sakari Ailus

Prev by Date: Re: [PATCH 0/8] of: automate of_node_put() - new approach to loops.
Next by Date: Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
Previous by thread: Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
Next by thread: Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
Index(es):
- Date
- Thread

[Index of Archives] [Linux IBM ACPI] [Linux Power Management] [Linux Kernel] [Linux Laptop] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]