Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Date: Mon, 12 Feb 2024 12:58:03 +0000
Cc: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>, Jonathan Cameron <jic23@xxxxxxxxxx>, linux-iio@xxxxxxxxxxxxxxx, "Rafael J . Wysocki" <rafael@xxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, linux-acpi@xxxxxxxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Daniel Scally <djrscally@xxxxxxxxx>, Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>, Julia Lawall <Julia.Lawall@xxxxxxxx>, Nuno Sá <nuno.sa@xxxxxxxxxx>, Cosmin Tanislav <cosmin.tanislav@xxxxxxxxxx>, Mihail Chindris <mihail.chindris@xxxxxxxxxx>, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>, Tomislav Denis <tomislav.denis@xxxxxxx>, Marek Vasut <marex@xxxxxxx>, Olivier Moysan <olivier.moysan@xxxxxxxxxxx>, Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>, Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>, Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>, Marius Cristea <marius.cristea@xxxxxxxxxxxxx>, Ibrahim Tilki <Ibrahim.Tilki@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>
In-reply-to: <ZcoTOZzJ3ZhSD0oi@smile.fi.intel.com>
References: <20240211192540.340682-1-jic23@kernel.org> <20240211192540.340682-2-jic23@kernel.org> <Zcnbk6_9BU_trU9P@kekkonen.localdomain> <20240212114206.00005b9f@Huawei.com> <ZcoQ3sOcVYbwoHO7@kekkonen.localdomain> <ZcoTOZzJ3ZhSD0oi@smile.fi.intel.com>

On Mon, Feb 12, 2024 at 02:46:49PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 12, 2024 at 12:36:46PM +0000, Sakari Ailus wrote:
> > On Mon, Feb 12, 2024 at 11:42:06AM +0000, Jonathan Cameron wrote:
> 
> ...
> 
> > Hmm. In that case I'd rather make fwnode_handle_put() and similar trivial
> > functions macros.
> 
> This will kill the type-checking opportunity, so I'm against this move.

Then it could be made static inline and moved to the header. I suppose for
modern compilers there should be no difference in between the two
optimisation-wise.

-- 
Sakari Ailus

Follow-Ups:
- Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
  - From: Jonathan Cameron

References:
- [PATCH v2 00/14] device property / IIO: Use cleanup.h magic for fwnode_handle_put() handling.
  - From: Jonathan Cameron
- [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
  - From: Jonathan Cameron
- Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
  - From: Sakari Ailus
- Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
  - From: Jonathan Cameron
- Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
  - From: Sakari Ailus
- Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
  - From: Andy Shevchenko

Prev by Date: Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
Next by Date: Re: [PATCH 1/4] ACPICA: SRAT: Add RISC-V RINTC affinity structure
Previous by thread: Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
Next by thread: Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.
Index(es):
- Date
- Thread

[Index of Archives] [Linux IBM ACPI] [Linux Power Management] [Linux Kernel] [Linux Laptop] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]