On Tue, May 23, 2023 at 1:24 AM Dan Williams <dan.j.williams@xxxxxxxxx> wrote: > > Dave Jiang wrote: > > ACPI_CEDT_DSMAS_NON_VOLATILE should be defined as > > ACPI_CDAT_DSMAS_NON_VOLATILE. Fix misspelled define. > > > > Cc: Rafael J. Wysocki <rafael@xxxxxxxxxx> > > Cc: Len Brown <lenb@xxxxxxxxxx> > > Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx> > > > > --- > > See https://github.com/acpica/acpica/pull/874 > > Merged > > --- > > include/acpi/actbl1.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h > > index 81b9e794424d..15df363b9144 100644 > > --- a/include/acpi/actbl1.h > > +++ b/include/acpi/actbl1.h > > @@ -356,7 +356,7 @@ struct acpi_cdat_dsmas { > > > > /* Flags for subtable above */ > > > > -#define ACPI_CEDT_DSMAS_NON_VOLATILE (1 << 2) > > +#define ACPI_CDAT_DSMAS_NON_VOLATILE (1 << 2) > > This needs to come in through an ACPICA update. If that is going to happen > this cycle, great, if not then I would handle it as a merge fixup after > the fact. I.e. just live with the misspelling to keep this patch set > ACPICA unencumbered, unless Rafael has different thoughts. You can also submit an upstream ACPICA pull request with this change and resend the patch with a Link tag pointing to that PR. Then we'll decide how to handle it.