Re: [PATCH v2 4/4] acpi: Add defines for CDAT SSLBIS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 23, 2023 at 1:25 AM Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
>
> Dave Jiang wrote:
> > Add upstream port and any port definition for SSLBIS.
> >
> > Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> >
> > ---
> > See https://github.com/acpica/acpica/pull/874
> > Merged
> > ---
> >  include/acpi/actbl1.h |    3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> > index 15df363b9144..c6189fafe87f 100644
> > --- a/include/acpi/actbl1.h
> > +++ b/include/acpi/actbl1.h
> > @@ -419,6 +419,9 @@ struct acpi_cdat_sslbe {
> >       u16 reserved;
> >  };
> >
> > +#define ACPI_CDAT_SSLBIS_US_PORT     0x0100
> > +#define ACPI_CDAT_SSLBIS_ANY_PORT    0xffff
> > +
> >  /*******************************************************************************
> >   *
> >   * CEDT - CXL Early Discovery Table
>
> Similar to the last patch, just define these locally outside of
> include/acpi/actbl1.h in the patch that needs them and drop the ACPICA
> entanglement.

Yes, if they are not used anywhere else, it's better to do that.

The local definitions can be dropped later when upstream ACPICA acquires them.

That said, it would be prudent to submit an upstream ACPICA pull
request adding them too.



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux