On Tue, Nov 08, 2022 at 12:04:19PM +0100, Pierre Gondois wrote: > acpi_find_cache_levels() is used at a single place and is short > enough to be merged into the calling function. The removal allows > an easier renaming of the calling function in the next patch. > > Also reorder the parameters in the 'reversed Christmas tree' order. Not sure if the above is worth mentioning explicitly. Even if you do, 'parameters' sounds very confusing to at-least me. I was searching for the changes is some function parameters to understand what it was and finally realised you meant the stack variable declaration order here. Right ? Other than that, it looks good. Reviewed-by: Sudeep Holla <sudeep.holla@xxxxxxx> -- Regards, Sudeep