Re: [PATCH 3/5] ACPI: PPTT: Remove acpi_find_cache_levels()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 11/8/22 17:13, Sudeep Holla wrote:
On Tue, Nov 08, 2022 at 12:04:19PM +0100, Pierre Gondois wrote:
acpi_find_cache_levels() is used at a single place and is short
enough to be merged into the calling function. The removal allows
an easier renaming of the calling function in the next patch.

Also reorder the parameters in the 'reversed Christmas tree' order.

Not sure if the above is worth mentioning explicitly. Even if you do,
'parameters' sounds very confusing to at-least me. I was searching for
the changes is some function parameters to understand what it was and
finally realised you meant the stack variable declaration order here.
Right ?

Yes right, I will use another word.



Other than that, it looks good.

Reviewed-by: Sudeep Holla <sudeep.holla@xxxxxxx>


Regards,
Pierre



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux