Hi, On 6/21/22 04:37, Daniel Drake wrote: > On Mon, Jun 20, 2022 at 10:33 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> It is a no-op now because after that commit the acpi_ec struct >> which gets allocated when parsing the ECDT now gets re-used >> when parsing the DSDT if the EC's cmd + data addresses match. > > Got it. Seems rather clear indeed. > > Can you point out how to check these addresses from dmesg output. We > have several of them saved here from these models, including for some > of the ones you weren't able to find logs for. If you look for "ACPI: EC: " in the dmesg you shoud find 2 blocks of log lines like this (note the output has changed somewhat overtime): [ 0.642373] ACPI: EC: EC started [ 0.642375] ACPI: EC: interrupt blocked [ 0.651140] ACPI: EC: EC_CMD/EC_SC=0x66, EC_DATA=0x62 [ 0.651142] ACPI: EC: Boot ECDT EC used to handle transactions [ 1.191469] ACPI: EC: interrupt unblocked [ 1.191471] ACPI: EC: event unblocked [ 1.191491] ACPI: EC: EC_CMD/EC_SC=0x66, EC_DATA=0x62 [ 1.191493] ACPI: EC: GPE=0x16 [ 1.191496] ACPI: \_SB_.PCI0.LPCB.EC__: Boot ECDT EC initialization complete [ 1.191501] ACPI: \_SB_.PCI0.LPCB.EC__: EC: Used to handle transactions and events The first block is the ECDT probing, the second one is the DSDT probing and the addresses are in the: [ 0.651140] ACPI: EC: EC_CMD/EC_SC=0x66, EC_DATA=0x62 lines. Regards, Hans
