Hi Hans,
Thanks for looking at this.
On Mon, Jun 20, 2022 at 5:26 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> Which leaves commit 6306f0431914 ("ACPI: EC: Make more Asus laptops
> use ECDT _GPE"), which was committed way after the generic fix.
> But this was just due to slow upstreaming of it. This commit stems
> from Endless from 15 Aug 2017 (committed upstream 20 May 2021):
> https://github.com/endlessm/linux/pull/288
>
> The current code should work fine without this:
Your explanation of the code flow seems clear and logical, but I have
not checked the details. This is a bit of a tricky issue as you have
probably seen from history, we went in a couple of wrong directions
before we spotted the real cause.
The one thing I don't see clearly in your explanation (which I may
have read too quickly) is how the generic fix 69b957c26b32 is
responsible for making this a "no-op" code flow now.
We don't have access to any of the affected hardware any more, unfortunately.
For certainty I wonder if you could recreate this on another system.
Something like:
1. Create DSDT override which has the wrong _GPE value
2. Run the original 2017 kernel with that override and observe that
Linux uses that wrong value
3. Apply the generic fix and check that it uses the right one from the ECDT now
Daniel
