pon., 20 cze 2022 o 20:03 Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> napisał(a):
>
> On Mon, Jun 20, 2022 at 05:02:24PM +0200, Marcin Wojtas wrote:
> > In order to support both ACPI and DT, modify the generic
> > DSA code to use device_/fwnode_ equivalent routines.
> > No functional change is introduced by this patch.
>
> ...
>
> > int err;
> >
> > - if (!np && !pdata)
> > + if (!fwnode && !pdata)
> > return -EINVAL;
>
> Sounds like redundant check
>
> if (pdata)
> ...
> else
> compat_info = ...
> if (!compat_info)
> return -EINVAL
>
> ?
>
> > - if (np)
> > - compat_info = of_device_get_match_data(dev);
> > + if (fwnode)
> > + compat_info = device_get_match_data(dev);
> >
> > if (pdata) {
>
> Missed 'else' even in the original code (see above)?
>
fwnode/np is mutually exclusive with pdata, but imo nothing wrong with
adding 'else' here or update the condition as suggested above.
Thanks,
Marcin
> > compat_info = pdata_device_get_match_data(dev);
>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
