On Wednesday 26 December 2007 21:17:18 Matthew Garrett wrote: > + if (!wmi_external_handler) > + return AE_ALREADY_ACQUIRED; I'm not sure (mostly because I don't like dealing with typedefs around pointers, and this bit is also untested). > I'm also a bit > unhappy about only being able to register one notification handler, if > we consider the case where vendors add and remove WMI interfaces over > time - it might make sense to have individual small drivers rather than > one big one, which would mean a notification handler per GUID. Any > thoughts? Yes, a notification handler per GUID does make sense, so I'll add that to WMI. Also, many thanks for reviewing this. -Carlos -- E-Mail: carlos@xxxxxxxxxxxxxxxxxxx Web: strangeworlds.co.uk GPG Key ID: 0x23EE722D - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
