Re: [PATCH 4/4] [RFC] ACPI: WMI: Add sysfs userspace interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 27 December 2007 00:54:01 Carlos Corbacho wrote:
> On Wednesday 26 December 2007 19:38:22 Matthew Garrett wrote:
> > +               memcpy(guid_dev->bus_id, guid_string, 36);
> >
> > bus_id is only 20 bytes long at the moment...
>
> That's what the last patch in the series is the hack for (shortens this to
> 20 so you can at least see what this would like look, and test the GUID
> based autoloading) - although I think I forgot to resend that one with the
> last WMI series.
>
> Until this gets fixed upstream, the sysfs interface patch remains an RFC
> only.

The reason I'm a bit concerned about folding in the 20 byte limit is that I 
don't want to hit the case where we get a system with a bunch of GUIDs that 
only differ by the last 16 bytes and then fail to register the WMI driver.

Although I suppose in the short term, we don't know of such systems, nor do we 
have any real WMI drivers for them anyway, so this might be an acceptable 
trade off. So if you think the risk is worth it, I'll fold in the bus_id 
limit.

-Carlos
-- 
E-Mail: carlos@xxxxxxxxxxxxxxxxxxx
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux