Re: [PATCH 1/4] ACPI: WMI: Add ACPI-WMI mapping driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+acpi_status wmi_install_notify_handler(wmi_notify_handler handler, void 
*data)
+{
+       if (!handler)
+               return AE_BAD_PARAMETER;
+
+       if (!wmi_external_handler)
+               return AE_ALREADY_ACQUIRED;

Are you sure the negation on the second if is correct? I'm also a bit 
unhappy about only being able to register one notification handler, if 
we consider the case where vendors add and remove WMI interfaces over 
time - it might make sense to have individual small drivers rather than 
one big one, which would mean a notification handler per GUID. Any 
thoughts?
-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux