> I agree with everything Matthew wrote. No problem - thanks to both of you for the feedback. > Also, please move it to drivers/misc, to keep msi-laptop, > sony-laptop, asus-laptop, and thinkpad-acpi company. Will do. I assume that this list would still be the most appropriate place to submit such a driver? > You might consider naming it fujitsu-laptop as well, > since the driver depends on ACPI, but it really exists > to provide laptop features, not to implement part of the ACPI spec... > fuj02b1_acpi.c may be accurate, but nobody will know what it is. I agree with this. > Along those lines, it is generally a good idea to put > if (acpi_disabled) > return -ENODEV; Agreed. > Also, the driver needs somebody to volunteer to be > its maintainer before it can be merged. At this stage I would be happy to maintain it. > Finally, please run it through scripts/Lindent before the next edition. Will do. Thanks once again for your help and suggestions. I shall rework the patch in due course. Regards jonathan - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
