> > +static struct acpi_driver acpi_fujitsu_driver = {
> > + .name = ACPI_FUJITSU_DRIVER_NAME,
> > + .class = ACPI_FUJITSU_CLASS,
> > + .ids = ACPI_FUJITSU_HID,
>
> string isn't the right kind of pointer (anymore)
> see the other examples of setting acpi_driver.ids
>
> eg. from fan.c:
> static const struct acpi_device_id fan_device_ids[] = {
> {"PNP0C0B", 0},
> {"", 0},
> };
>
>
> .ids = fan_device_ids,
Ah, a 2.6.23 change. Ok, I'll make the change.
> > + .ops = {
> > + .add = acpi_fujitsu_add,
> > + .remove = acpi_fujitsu_remove,
> > + },
> > +};
> > +
> > +/* Initialization */
> > +
> > +static struct dmi_system_id __initdata fujitsu_dmi_table[] = {
> > + {
> > + .ident = "Fujitsu S7020",
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "LifeBook S7020"),
> > + }
> > + },
> > + {
> > + .ident = "Fujitsu generic laptop",
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> > + }
> > + },
> > + {}
> > +};
>
> I don't understand why you need the DMI match stuff if you're binding on
> the PNPid FUJ02B1.
You're right - we probably don't now you come to mention it. It's in there
because the msi-laptop.c used a similar approach and I figured it can't
hurt.
> Further, I don't understand if you need the DMI match stuff, the value of
> the 1st entry when the 2nd entry is present.
The idea was to provide a "generic" entry which would match against other
Fujitsu laptops such as the P-series. I don't have such a laptop to test
against, so this at least would have allowed the module to load in these
other laptops without having to do anything special.
> Plus, wouldn't that match on a FUJITSU server as well?
No idea - I don't have a Fujitsu server so I can't determine what its DMI
info actually is. That's fine though - if the PNPid is regarded as being
sufficient (and on reflection it seems to be) then I'll just go with that.
Regards
jonathan
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
