On Thursday 23 August 2007 22:13, Len Brown wrote: > I agree with everything Matthew wrote. > > Also, please move it to drivers/misc, to keep msi-laptop, > sony-laptop, asus-laptop, and thinkpad-acpi company. > > toshiba-acpi is in drivers/acpi just because it is being neglected -- > but the new scheme is for platform specific drivers that > use ACPI is to put them in drivers/misc; and /drivers/acpi > is for stuff that implements generic ACPI code. > > You might consider naming it fujitsu-laptop as well, > since the driver depends on ACPI, but it really exists > to provide laptop features, not to implement part of the ACPI spec... > fuj02b1_acpi.c may be accurate, but nobody will know what it is. > > Along those lines, it is generally a good idea to put > if (acpi_disabled) > return -ENODEV; > > in the init function if the driver is worthless without ACPI. > > Also, the driver needs somebody to volunteer to be > its maintainer before it can be merged. > > Finally, please run it through scripts/Lindent before the next edition. Oh, i forgot to mention also... There should be no new files created under /proc/acpi for platform specific drivers. thanks, -Len - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
