On Thu, 15 Mar 2007, Kristen Carlson Accardi wrote: > I think we should focus our efforts on a generic (non platform specific) > solution that can work across many laptops (i.e. ACPI_BAY). Let's make Agreed, as long as that doesn't mean we have to pollute ACPI_BAY with a truckload of crap required to deal with vendor/model-specific idioticities. I hope ThinkPads are not like that, but I am not sure, and I'd feel bad about adding a lot of quirks to ACPI_BAY because of ThinkPad weirdness :p Otherwise, it would be best to allow model-specific modules to provide extra functionality for ACPI_BAY, that way we have generic code, and we can contain the braindamage to where it belongs (e.g. in ibm-acpi). > so if you do have time to work on this, that would be great. I am happy > to test on the set of laptops I've got. I will see what I can do. My "first approach" at a requirements list for a proper bay module are as follows: 1. It will handle all device types (ATAPI, PATA, SATA, batteries); 2. It will do the right thing on plug and unplug. This means telling the rest of the kernel to disable the device in the bay, for example. Right now we shutdown one end of the PATA/SATA link on ThinkPads eletrically, and leave libata to scream blood murder until it disables its end due to too many retries, for example; 3. It will allow model-specific drivers (like ibm-acpi) to be notified of bay events (callbacks or a notifier chain, since ACPICA doesn't allow for more than one driver notifier per handle) and to request an immediate attempt of ejection or hotplug/bay device change verification. Some thinkpads benefit from an eject before S3 sleep -- as long as what is inside is not a battery... I don't see why the generic driver could not do all of the above. But it will take a while to get there :-) And no, ibm-acpi can't do much more than (1). -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
