Re: Build fails in pdfium

[Miklos Vajna <vmiklos@xxxxxxxxxxxxx>]

Hi Regina,

On Fri, Feb 14, 2025 at 12:48:01AM +0100, Regina Henschel <rb.henschel@xxxxxxxxxxx> wrote:
> a clean build with Cygwin fails in pdfium.
> For example:
> 
> C:\buildLo\core\workdir\UnpackedTarball\pdfium\core/fxcrt/byteorder.h(21):
> fatal error C1189: #error:  "MSVC is not supported."
> 
> C:\buildLo\core\workdir\UnpackedTarball\pdfium\core/fxcrt/immediate_crash.h(138):
> error C2059: syntax error: 'volatile'

See the commit message of 6007fbef5c2e4a0b80a4c0031ff36117aa41e63f
(Update pdfium to 7012, 2025-02-13), pdfium dropped support for MSVC, so
we have to build pdfium with clang-cl, similar to skia.

external/pdfium/Library_pdfium.mk:16 does ask pdfium to be built with
clang-cl, though; otherwise Jenkins would hit the same problem.

I wonder why that's not the case for you, perhaps you also use
--disable-skia? --disable-skia --enable-pdfium is not a combination I
tried.

If so, can you try removing --disable-skia and see if that helps?

> I have used with --disable-pdfium now (until the problem is fixed).

That's an effective workaround for now, but it would be still good to
understand why something fails for you when it works on Jenkins.

Thanks,

Miklos