On 31.8.2024 20.12, khagaroth wrote:
On Thu, Aug 29, 2024 at 4:53 PM Miklos Vajna <vmiklos@xxxxxxxxxxxxx
<mailto:vmiklos@xxxxxxxxxxxxx>> wrote:
* Cell indicator in 24.8 branch (Xisco)
+ Summary:
https://bugs.documentfoundation.org/show_bug.cgi?id=162646#c20
<https://bugs.documentfoundation.org/show_bug.cgi?id=162646#c20>
+ two topics: comment indicator and focus rectangle; no revert
please (Heiko)
+ the fear is that what's there in 24.8 is half-done (Xisco)
+ comments are mixed (Ilmari)
+ some people like what's in master
+ just today 2 commits were backported
+ one more patch to merge to 24-8, would be ideal even on 24-8-1
+ the issue is quite old, the focus rectangle of a cell was
painted inside the cell (Heiko)
+ then tried outside the cell to not cover content
+ design team suggestion was: push it to the release, see what
the wider community likes
+ meanwhile Rafael improved this, seems people are happy with
the current state
+ hope the problem is fixed
+ would like to avoid adding more options for this
+ would be good to wait, collect input and not just revert quickly
+ do you support backporting the relevant changes from master?
(Ilmari)
+ like it (Heiko)
+ fine with this, just good to not experiment on release
branches (Xisco)+
> Ignoring the subjectively ugly look (thankfully not as ugly and buggy as
> it was before the fixes). This change just replaced obscuring inner
> content with obscuring content of surrounding cells, so I would not call
> it much of an improvement, if any. It should behave the same way as MSO
> and just highlight the existing grid lines and not obscure anything.
The current state, now backported to 24.8.1, does match Excel's
behaviour. The indicator in Excel goes slightly beyond the cell borders
unlike you claim.
Ilmari
