New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
17 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1618766:  Error handling issues  (CHECKED_RETURN)
/sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx: 199 in ScXMLChangeTrackingImportHelper::GetIDFromString(std::basic_string_view<char, std::char_traits<char>>)()


________________________________________________________________________________________________________
*** CID 1618766:  Error handling issues  (CHECKED_RETURN)
/sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx: 199 in ScXMLChangeTrackingImportHelper::GetIDFromString(std::basic_string_view<char, std::char_traits<char>>)()
193         sal_uInt32 nResult(0);
194         if (!sID.empty())
195         {
196             if (sID.substr(0, SC_CHANGE_ID_PREFIX.getLength()) == SC_CHANGE_ID_PREFIX)
197             {
198                 sal_Int32 nValue;
>>>     CID 1618766:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "convertNumber" without checking return value (as is done elsewhere 21 out of 22 times).
199                 ::sax::Converter::convertNumber(nValue, sID.substr(SC_CHANGE_ID_PREFIX.getLength()),
200                                                 0, SAL_MAX_INT32);
201                 OSL_ENSURE(nValue > 0, "wrong change action ID");
202                 nResult = nValue;
203             }
204             else

** CID 1618765:    (PASS_BY_VALUE)
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)256, frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)256>, frozen::bits::carray<unsigned long, (unsigned long)256>, frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>>)()
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)32, frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)32>, frozen::bits::carray<unsigned long, (unsigned long)32>, frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>>)()
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)64, frozen::elsa<int>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)64>, frozen::bits::carray<unsigned long, (unsigned long)64>, frozen::elsa<int>)()
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)64, frozen::elsa<model::SystemColorType>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)64>, frozen::bits::carray<unsigned long, (unsigned long)64>, frozen::elsa<model::SystemColorType>)()
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)32, frozen::elsa<unsigned short>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)32>, frozen::bits::carray<unsigned long, (unsigned long)32>, frozen::elsa<unsigned short>)()
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)256, frozen::elsa<int>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)256>, frozen::bits::carray<unsigned long, (unsigned long)256>, frozen::elsa<int>)()
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)64, frozen::elsa<writerfilter::rtftok::RTFKeyword>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)64>, frozen::bits::carray<unsigned long, (unsigned long)64>, frozen::elsa<writerfilter::rtftok::RTFKeyword>)()
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)32, frozen::elsa<GfxLinkType>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)32>, frozen::bits::carray<unsigned long, (unsigned long)32>, frozen::elsa<GfxLinkType>)()
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)32, frozen::elsa<int>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)32>, frozen::bits::carray<unsigned long, (unsigned long)32>, frozen::elsa<int>)()
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)64, frozen::elsa<oox::Relationship>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)64>, frozen::bits::carray<unsigned long, (unsigned long)64>, frozen::elsa<oox::Relationship>)()
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)32, frozen::elsa<model::ThemeColorType>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)32>, frozen::bits::carray<unsigned long, (unsigned long)32>, frozen::elsa<model::ThemeColorType>)()
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)64, frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)64>, frozen::bits::carray<unsigned long, (unsigned long)64>, frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>>)()
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)64, frozen::elsa<orcus::character_set_t>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)64>, frozen::bits::carray<unsigned long, (unsigned long)64>, frozen::elsa<orcus::character_set_t>)()
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)32, frozen::elsa<oox::drawingml::PredefinedClrSchemeId>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)32>, frozen::bits::carray<unsigned long, (unsigned long)32>, frozen::elsa<oox::drawingml::PredefinedClrSchemeId>)()


________________________________________________________________________________________________________
*** CID 1618765:    (PASS_BY_VALUE)
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)256, frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)256>, frozen::bits::carray<unsigned long, (unsigned long)256>, frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>>)()
152       std::uint64_t first_seed_;
153       carray<seed_or_index, M> first_table_;
154       carray<std::size_t, M> second_table_;
155     
156       constexpr pmh_tables(
157           std::uint64_t first_seed,
>>>     CID 1618765:    (PASS_BY_VALUE)
>>>     Passing parameter first_table of type "frozen::bits::carray<frozen::bits::seed_or_index, 256ul>" (size 2048 bytes) by value, which exceeds the high threshold of 512 bytes.
158           carray<seed_or_index, M> first_table,
159           carray<std::size_t, M> second_table,
160           Hasher hash) noexcept
161         : Hasher(hash)
162         , first_seed_(first_seed)
163         , first_table_(first_table)
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)32, frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)32>, frozen::bits::carray<unsigned long, (unsigned long)32>, frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>>)()
152       std::uint64_t first_seed_;
153       carray<seed_or_index, M> first_table_;
154       carray<std::size_t, M> second_table_;
155     
156       constexpr pmh_tables(
157           std::uint64_t first_seed,
>>>     CID 1618765:    (PASS_BY_VALUE)
>>>     Passing parameter first_table of type "frozen::bits::carray<frozen::bits::seed_or_index, 32ul>" (size 256 bytes) by value, which exceeds the low threshold of 128 bytes.
158           carray<seed_or_index, M> first_table,
159           carray<std::size_t, M> second_table,
160           Hasher hash) noexcept
161         : Hasher(hash)
162         , first_seed_(first_seed)
163         , first_table_(first_table)
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)64, frozen::elsa<int>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)64>, frozen::bits::carray<unsigned long, (unsigned long)64>, frozen::elsa<int>)()
152       std::uint64_t first_seed_;
153       carray<seed_or_index, M> first_table_;
154       carray<std::size_t, M> second_table_;
155     
156       constexpr pmh_tables(
157           std::uint64_t first_seed,
>>>     CID 1618765:    (PASS_BY_VALUE)
>>>     Passing parameter first_table of type "frozen::bits::carray<frozen::bits::seed_or_index, 64ul>" (size 512 bytes) by value, which exceeds the medium threshold of 256 bytes.
158           carray<seed_or_index, M> first_table,
159           carray<std::size_t, M> second_table,
160           Hasher hash) noexcept
161         : Hasher(hash)
162         , first_seed_(first_seed)
163         , first_table_(first_table)
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)64, frozen::elsa<model::SystemColorType>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)64>, frozen::bits::carray<unsigned long, (unsigned long)64>, frozen::elsa<model::SystemColorType>)()
152       std::uint64_t first_seed_;
153       carray<seed_or_index, M> first_table_;
154       carray<std::size_t, M> second_table_;
155     
156       constexpr pmh_tables(
157           std::uint64_t first_seed,
>>>     CID 1618765:    (PASS_BY_VALUE)
>>>     Passing parameter first_table of type "frozen::bits::carray<frozen::bits::seed_or_index, 64ul>" (size 512 bytes) by value, which exceeds the medium threshold of 256 bytes.
158           carray<seed_or_index, M> first_table,
159           carray<std::size_t, M> second_table,
160           Hasher hash) noexcept
161         : Hasher(hash)
162         , first_seed_(first_seed)
163         , first_table_(first_table)
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)32, frozen::elsa<unsigned short>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)32>, frozen::bits::carray<unsigned long, (unsigned long)32>, frozen::elsa<unsigned short>)()
152       std::uint64_t first_seed_;
153       carray<seed_or_index, M> first_table_;
154       carray<std::size_t, M> second_table_;
155     
156       constexpr pmh_tables(
157           std::uint64_t first_seed,
>>>     CID 1618765:    (PASS_BY_VALUE)
>>>     Passing parameter first_table of type "frozen::bits::carray<frozen::bits::seed_or_index, 32ul>" (size 256 bytes) by value, which exceeds the low threshold of 128 bytes.
158           carray<seed_or_index, M> first_table,
159           carray<std::size_t, M> second_table,
160           Hasher hash) noexcept
161         : Hasher(hash)
162         , first_seed_(first_seed)
163         , first_table_(first_table)
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)256, frozen::elsa<int>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)256>, frozen::bits::carray<unsigned long, (unsigned long)256>, frozen::elsa<int>)()
152       std::uint64_t first_seed_;
153       carray<seed_or_index, M> first_table_;
154       carray<std::size_t, M> second_table_;
155     
156       constexpr pmh_tables(
157           std::uint64_t first_seed,
>>>     CID 1618765:    (PASS_BY_VALUE)
>>>     Passing parameter first_table of type "frozen::bits::carray<frozen::bits::seed_or_index, 256ul>" (size 2048 bytes) by value, which exceeds the high threshold of 512 bytes.
158           carray<seed_or_index, M> first_table,
159           carray<std::size_t, M> second_table,
160           Hasher hash) noexcept
161         : Hasher(hash)
162         , first_seed_(first_seed)
163         , first_table_(first_table)
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)64, frozen::elsa<writerfilter::rtftok::RTFKeyword>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)64>, frozen::bits::carray<unsigned long, (unsigned long)64>, frozen::elsa<writerfilter::rtftok::RTFKeyword>)()
152       std::uint64_t first_seed_;
153       carray<seed_or_index, M> first_table_;
154       carray<std::size_t, M> second_table_;
155     
156       constexpr pmh_tables(
157           std::uint64_t first_seed,
>>>     CID 1618765:    (PASS_BY_VALUE)
>>>     Passing parameter first_table of type "frozen::bits::carray<frozen::bits::seed_or_index, 64ul>" (size 512 bytes) by value, which exceeds the medium threshold of 256 bytes.
158           carray<seed_or_index, M> first_table,
159           carray<std::size_t, M> second_table,
160           Hasher hash) noexcept
161         : Hasher(hash)
162         , first_seed_(first_seed)
163         , first_table_(first_table)
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)32, frozen::elsa<GfxLinkType>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)32>, frozen::bits::carray<unsigned long, (unsigned long)32>, frozen::elsa<GfxLinkType>)()
152       std::uint64_t first_seed_;
153       carray<seed_or_index, M> first_table_;
154       carray<std::size_t, M> second_table_;
155     
156       constexpr pmh_tables(
157           std::uint64_t first_seed,
>>>     CID 1618765:    (PASS_BY_VALUE)
>>>     Passing parameter first_table of type "frozen::bits::carray<frozen::bits::seed_or_index, 32ul>" (size 256 bytes) by value, which exceeds the low threshold of 128 bytes.
158           carray<seed_or_index, M> first_table,
159           carray<std::size_t, M> second_table,
160           Hasher hash) noexcept
161         : Hasher(hash)
162         , first_seed_(first_seed)
163         , first_table_(first_table)
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)32, frozen::elsa<int>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)32>, frozen::bits::carray<unsigned long, (unsigned long)32>, frozen::elsa<int>)()
152       std::uint64_t first_seed_;
153       carray<seed_or_index, M> first_table_;
154       carray<std::size_t, M> second_table_;
155     
156       constexpr pmh_tables(
157           std::uint64_t first_seed,
>>>     CID 1618765:    (PASS_BY_VALUE)
>>>     Passing parameter first_table of type "frozen::bits::carray<frozen::bits::seed_or_index, 32ul>" (size 256 bytes) by value, which exceeds the low threshold of 128 bytes.
158           carray<seed_or_index, M> first_table,
159           carray<std::size_t, M> second_table,
160           Hasher hash) noexcept
161         : Hasher(hash)
162         , first_seed_(first_seed)
163         , first_table_(first_table)
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)64, frozen::elsa<oox::Relationship>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)64>, frozen::bits::carray<unsigned long, (unsigned long)64>, frozen::elsa<oox::Relationship>)()
152       std::uint64_t first_seed_;
153       carray<seed_or_index, M> first_table_;
154       carray<std::size_t, M> second_table_;
155     
156       constexpr pmh_tables(
157           std::uint64_t first_seed,
>>>     CID 1618765:    (PASS_BY_VALUE)
>>>     Passing parameter first_table of type "frozen::bits::carray<frozen::bits::seed_or_index, 64ul>" (size 512 bytes) by value, which exceeds the medium threshold of 256 bytes.
158           carray<seed_or_index, M> first_table,
159           carray<std::size_t, M> second_table,
160           Hasher hash) noexcept
161         : Hasher(hash)
162         , first_seed_(first_seed)
163         , first_table_(first_table)
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)32, frozen::elsa<model::ThemeColorType>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)32>, frozen::bits::carray<unsigned long, (unsigned long)32>, frozen::elsa<model::ThemeColorType>)()
152       std::uint64_t first_seed_;
153       carray<seed_or_index, M> first_table_;
154       carray<std::size_t, M> second_table_;
155     
156       constexpr pmh_tables(
157           std::uint64_t first_seed,
>>>     CID 1618765:    (PASS_BY_VALUE)
>>>     Passing parameter first_table of type "frozen::bits::carray<frozen::bits::seed_or_index, 32ul>" (size 256 bytes) by value, which exceeds the low threshold of 128 bytes.
158           carray<seed_or_index, M> first_table,
159           carray<std::size_t, M> second_table,
160           Hasher hash) noexcept
161         : Hasher(hash)
162         , first_seed_(first_seed)
163         , first_table_(first_table)
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)64, frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)64>, frozen::bits::carray<unsigned long, (unsigned long)64>, frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>>)()
152       std::uint64_t first_seed_;
153       carray<seed_or_index, M> first_table_;
154       carray<std::size_t, M> second_table_;
155     
156       constexpr pmh_tables(
157           std::uint64_t first_seed,
>>>     CID 1618765:    (PASS_BY_VALUE)
>>>     Passing parameter first_table of type "frozen::bits::carray<frozen::bits::seed_or_index, 64ul>" (size 512 bytes) by value, which exceeds the medium threshold of 256 bytes.
158           carray<seed_or_index, M> first_table,
159           carray<std::size_t, M> second_table,
160           Hasher hash) noexcept
161         : Hasher(hash)
162         , first_seed_(first_seed)
163         , first_table_(first_table)
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)64, frozen::elsa<orcus::character_set_t>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)64>, frozen::bits::carray<unsigned long, (unsigned long)64>, frozen::elsa<orcus::character_set_t>)()
152       std::uint64_t first_seed_;
153       carray<seed_or_index, M> first_table_;
154       carray<std::size_t, M> second_table_;
155     
156       constexpr pmh_tables(
157           std::uint64_t first_seed,
>>>     CID 1618765:    (PASS_BY_VALUE)
>>>     Passing parameter first_table of type "frozen::bits::carray<frozen::bits::seed_or_index, 64ul>" (size 512 bytes) by value, which exceeds the medium threshold of 256 bytes.
158           carray<seed_or_index, M> first_table,
159           carray<std::size_t, M> second_table,
160           Hasher hash) noexcept
161         : Hasher(hash)
162         , first_seed_(first_seed)
163         , first_table_(first_table)
/workdir/UnpackedTarball/frozen/include/frozen/bits/pmh.h: 158 in frozen::bits::pmh_tables<(unsigned long)32, frozen::elsa<oox::drawingml::PredefinedClrSchemeId>>::pmh_tables(unsigned long, frozen::bits::carray<frozen::bits::seed_or_index, (unsigned long)32>, frozen::bits::carray<unsigned long, (unsigned long)32>, frozen::elsa<oox::drawingml::PredefinedClrSchemeId>)()
152       std::uint64_t first_seed_;
153       carray<seed_or_index, M> first_table_;
154       carray<std::size_t, M> second_table_;
155     
156       constexpr pmh_tables(
157           std::uint64_t first_seed,
>>>     CID 1618765:    (PASS_BY_VALUE)
>>>     Passing parameter first_table of type "frozen::bits::carray<frozen::bits::seed_or_index, 32ul>" (size 256 bytes) by value, which exceeds the low threshold of 128 bytes.
158           carray<seed_or_index, M> first_table,
159           carray<std::size_t, M> second_table,
160           Hasher hash) noexcept
161         : Hasher(hash)
162         , first_seed_(first_seed)
163         , first_table_(first_table)

** CID 1618764:    (CONSTANT_EXPRESSION_RESULT)
/include/rtl/stringutils.hxx: 126 in rtl::libreoffice_internal::IsValidStrLen<unsigned char, (int)0>(T1, int)()
/include/rtl/stringutils.hxx: 126 in rtl::libreoffice_internal::IsValidStrLen<unsigned short, (int)0>(T1, int)()


________________________________________________________________________________________________________
*** CID 1618764:    (CONSTANT_EXPRESSION_RESULT)
/include/rtl/stringutils.hxx: 126 in rtl::libreoffice_internal::IsValidStrLen<unsigned char, (int)0>(T1, int)()
120     #if defined LIBO_INTERNAL_ONLY
121     template <typename I, std::enable_if_t<std::is_integral_v<I>, int> = 0>
122     constexpr bool IsValidStrLen(I i, sal_Int32 margin = 0)
123     {
124         assert(margin >= 0);
125         constexpr sal_uInt32 maxLen = std::numeric_limits<sal_Int32>::max();
>>>     CID 1618764:    (CONSTANT_EXPRESSION_RESULT)
>>>     "i >= 0" is always true regardless of the values of its operands. This occurs as the logical first operand of "&&".
126         return i >= 0 && static_cast<std::make_unsigned_t<I>>(i) <= maxLen - margin;
127     }
128     template <typename I, std::enable_if_t<std::is_integral_v<I>, int> = 0>
129     sal_Int32 ThrowIfInvalidStrLen(I i, sal_Int32 margin = 0)
130     {
131         if (!IsValidStrLen(i, margin))
/include/rtl/stringutils.hxx: 126 in rtl::libreoffice_internal::IsValidStrLen<unsigned short, (int)0>(T1, int)()
120     #if defined LIBO_INTERNAL_ONLY
121     template <typename I, std::enable_if_t<std::is_integral_v<I>, int> = 0>
122     constexpr bool IsValidStrLen(I i, sal_Int32 margin = 0)
123     {
124         assert(margin >= 0);
125         constexpr sal_uInt32 maxLen = std::numeric_limits<sal_Int32>::max();
>>>     CID 1618764:    (CONSTANT_EXPRESSION_RESULT)
>>>     "i >= 0" is always true regardless of the values of its operands. This occurs as the logical first operand of "&&".
126         return i >= 0 && static_cast<std::make_unsigned_t<I>>(i) <= maxLen - margin;
127     }
128     template <typename I, std::enable_if_t<std::is_integral_v<I>, int> = 0>
129     sal_Int32 ThrowIfInvalidStrLen(I i, sal_Int32 margin = 0)
130     {
131         if (!IsValidStrLen(i, margin))


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DoVJJ_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGttrfgG-2FzzEqvLaaAbm9SNl-2FcASAmm91KVShQWmIMMwfoRYpeYh11XahgloPHy8ZAdtAXnHHWJyURZHhPhalMiQS1YRW8jMUZodmtY9TrEnAsnj4WwSdjRhcxKcwyXvr3fomY7TZ7wipAYtvnPrneovHLmakF-2FXNBpew-2BUxT546wo-3D