New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
14 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1597274:  Incorrect expression  (IDENTICAL_BRANCHES)
/sd/source/ui/app/sdmod2.cxx: 735 in SdModule::ApplyItemSet(unsigned short, const SfxItemSet &)()


________________________________________________________________________________________________________
*** CID 1597274:  Incorrect expression  (IDENTICAL_BRANCHES)
/sd/source/ui/app/sdmod2.cxx: 735 in SdModule::ApplyItemSet(unsigned short, const SfxItemSet &)()
729     
730         // Only if also the document type matches...
731         if( pDocSh && pDoc && eDocType == pDoc->GetDocumentType() )
732         {
733             FieldUnit eUIUnit;
734             SvtSysLocale aSysLocale;
>>>     CID 1597274:  Incorrect expression  (IDENTICAL_BRANCHES)
>>>     The same code is executed regardless of whether "eDocType == DocumentType::Impress" is true, because the 'then' and 'else' branches are identical. Should one of the branches be modified, or the entire 'if' statement replaced?
735             if (eDocType == DocumentType::Impress)
736                 if (aSysLocale.GetLocaleData().getMeasurementSystemEnum() == MeasurementSystem::Metric)
737                     eUIUnit = static_cast<FieldUnit>(officecfg::Office::Impress::Layout::Other::MeasureUnit::Metric::get());
738                 else
739                     eUIUnit = static_cast<FieldUnit>(officecfg::Office::Impress::Layout::Other::MeasureUnit::NonMetric::get());
740             else

** CID 1597273:  Error handling issues  (CHECKED_RETURN)
/dbaccess/source/ui/browser/unodatbr.cxx: 2162 in dbaui::SbaTableQueryBrowser::OnExpandEntry(const weld::TreeIter &)()


________________________________________________________________________________________________________
*** CID 1597273:  Error handling issues  (CHECKED_RETURN)
/dbaccess/source/ui/browser/unodatbr.cxx: 2162 in dbaui::SbaTableQueryBrowser::OnExpandEntry(const weld::TreeIter &)()
2156         if (etTableContainer == pData->eType)
2157         {
2158             weld::WaitObject aWaitCursor(getFrameWeld());
2159     
2160             // it could be that we already have a connection
2161             SharedConnection xConnection;
>>>     CID 1597273:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "ensureConnection" without checking return value (as is done elsewhere 4 out of 5 times).
2162             ensureConnection(xFirstParent.get(), xConnection);
2163     
2164             if ( xConnection.is() )
2165             {
2166                 SQLExceptionInfo aInfo;
2167                 try


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DyvG3_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtKcSBmBEvTNeRuiIvP564cBNHH-2BnkseL5EtBP-2BeZzQbE1g97Np-2BpvZKquT0r5hu-2FR0xG2hOM4vNeYySn05u6OrlYAsxbmWDQfrI7UK8gKm0ghYRf9KG90CCzmk2fLGZk-2FmvpozqJ-2FWmGrXV21IxRBwyOAk2EDdxDyVQ1S9tg8wTY-3D