New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1515535:  Null pointer dereferences  (FORWARD_NULL)
/vcl/source/fontsubset/sft.cxx: 2176 in vcl::CreateT42FromTTGlyphs(vcl::TrueTypeFont *, _IO_FILE *, const char *, const unsigned short *, unsigned char *, int)()


________________________________________________________________________________________________________
*** CID 1515535:  Null pointer dereferences  (FORWARD_NULL)
/vcl/source/fontsubset/sft.cxx: 2176 in vcl::CreateT42FromTTGlyphs(vcl::TrueTypeFont *, _IO_FILE *, const char *, const unsigned short *, unsigned char *, int)()
2170     
2171         DumpSfnts(outf, aOutBuffer.data(), aOutBuffer.size());
2172     
2173         /* dump charstrings */
2174         fprintf(outf, "/CharStrings %d dict dup begin\n", nGlyphs);
2175         fprintf(outf, "/.notdef 0 def\n");
>>>     CID 1515535:  Null pointer dereferences  (FORWARD_NULL)
>>>     Attempting to access the managed object of an empty smart pointer "glyf".
2176         for (i = 1; i < static_cast<int>(glyf->glyfCount()); i++) {
2177             fprintf(outf,"/glyph%d %d def\n", i, i);
2178         }
2179         fprintf(outf, "end readonly def\n");
2180     
2181         fprintf(outf, "FontName currentdict end definefont pop\n");

** CID 1515534:  API usage errors  (INVALIDATE_ITERATOR)
/vcl/source/fontsubset/ttcr.cxx: 140 in vcl::TrueTypeCreator::RemoveTable(unsigned int)()


________________________________________________________________________________________________________
*** CID 1515534:  API usage errors  (INVALIDATE_ITERATOR)
/vcl/source/fontsubset/ttcr.cxx: 140 in vcl::TrueTypeCreator::RemoveTable(unsigned int)()
134             this->m_tables.push_back(std::move(table));
135         }
136     }
137     
138     void TrueTypeCreator::RemoveTable(sal_uInt32 tableTag)
139     {
>>>     CID 1515534:  API usage errors  (INVALIDATE_ITERATOR)
>>>     Using invalid iterator "it".
140         for (auto it = this->m_tables.begin(); it != this->m_tables.end(); ++it)
141         {
142             if ((*it)->m_tag == tableTag)
143             {
144                 this->m_tables.erase(it);
145             }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D4mH3_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJie5cgINjl9FJBuHaYS1KlL-2B5u4fsuMax1-2F7zO8NxYDJy-2FzhurbfgTOsMUR4RJv1EZ-2FBCbYjmgceiQKodRLPt-2FRpUp-2F9BOR9mdzPdEnBRlaXe-2FgH4RWbUW7VUXl7hP6LMkS3GjsJq-2BpuInkdf8Qk-2BA2t4CyYnhSef0yLtLfTG5iMg-3D