Re: proposition for patch in CommonSalLayout.cxx

[julien2412 <serval2412@xxxxxxxx>]

Stanisław Jeśmanowicz wrote
>>
> This is not always the case, because if a platform didn't include
> graphite2 shaper in its HarfBuzz 
> implementaion, you won't have it anyway ( like ./configure
> --with-graphite2=no )
> Even if you set it the shapers list (as in 
> https://cgit.freedesktop.org/libreoffice/core/commit/?id=3cee50476e422e3ed84169cdcbe6bd9883fc9316
> )
> And if graphite2 shaper is implemented, then it will be first (as you can
> see in the harfbuzz code: 
> https://github.com/harfbuzz/harfbuzz/blob/master/src/hb-shaper-list.hh )
> And generally speaking, hard-coded list in such a case disables possible
> new shapers.

Perhaps the goal was indeed to avoid non tested new shapers in LO that could
bring some havoc.
So by hard coding shapers, you're sure you won't have problems.
Now of course, if nobody ever test new shapers, LO will be stuck with old
ones.

Anyway, now you got an account, once you had already submitted your license
(see
https://wiki.documentfoundation.org/Development/GetInvolved#License_statement),
I'll put Khaled in cc, he certainly will bring interesting thoughts here.

Julien



--
Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice