Re: proposition for patch in CommonSalLayout.cxx

[julien2412 <serval2412@xxxxxxxx>]

Stanisław Jeśmanowicz wrote
> ...
> Thank you for your advice, but getting familiar with gerrit on top of git
> would take some time for 
> me now.
> I hope, that some of your developers could commit this patch for me in vcl
> module.
> It is simple and won't harm anything.
> But people could benefit from it on all platforms that use system's native
> HarfBuzz implementation.
> ...

I can understand you don't have time for gerrit but would it be possible you
submit a license statement?

About this line, I retrieved the initial patches which put this line:
1) earliest
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3cee50476e422e3ed84169cdcbe6bd9883fc9316:
Author: Khaled Hosny <khaledhosny@xxxxxxxxx>
Date:   Fri Mar 10 16:53:08 2017 +0200

    tdf#106466: Use graphite2 shaper first
    
    We want to always prefer Graphite shaping when supported by the font,
    which is also what HarfBuzz does by default.
    
    Change-Id: I6670fc03b8e6b3d7e07e1b8e0062880524da1655
    Reviewed-on: https://gerrit.libreoffice.org/35046
    Tested-by: Jenkins <ci@xxxxxxxxxxxxxxx>
    Reviewed-by: Khaled Hosny <khaledhosny@xxxxxxxxx>


2) oldest
https://cgit.freedesktop.org/libreoffice/core/commit/?id=7854d35cd8172b201f1f3ad247860f242e5cb06b
Author: Khaled Hosny <khaledhosny@xxxxxxxxx>
Date:   Thu Oct 6 04:15:41 2016 +0200

    Use HarfBuzz shape plan for a bit more control
    
    This way we control exactly what shapers we use in what order, and as an
    extra we can now tell which shaper HarfBuzz ends up using.

Julien



--
Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice