On 24/03/2020 11:37, julien2412 wrote:
Ok forget about the tdf part, it was just the starting point, I'd like to know if for example "officecfg::Inet::Settings::ooInetHTTPProxyName::get()" should be used in "SvxProxyTabPage::ReadConfigData_Impl " or in "SvxProxyTabPage::ReadConfigDefaults_Impl"
The css::container::XNameAccess::getByName calls in SvxProxyTabPage::ReadConfigData_Impl (cui/source/options/optinet2.cxx) could be replaced with the simplified C++ configuration access as discussed in <https://bugs.documentfoundation.org/show_bug.cgi?id=46037> "Clean up uses of comphelper/configurationhelper.hxx".
The css::beans::XPropertyState::getPropertyDefault calls in SvxProxyTabPage::ReadConfigDefaults_Impl (cui/source/options/optinet2.cxx) cannot be replaced with the simplified C++ configuration access. This is a kind of access that is not modeled by that simplified API. (And as discussed in <https://bugs.documentfoundation.org/show_bug.cgi?id=33697> "Unable to choose proxy type 'system'", with the current configmgr implementation, the relevant objects fail to implement that css::beans::XPropertyState interface, so SvxProxyTabPage::ReadConfigDefaults_Impl will always go into the css::uno::RuntimeException catch block and effectively do nothing.)
_______________________________________________ LibreOffice mailing list LibreOffice@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/libreoffice
