On Mon, 13 May 2013 21:02:10 +0800 Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxxxxxx> wrote: > On 05/13/2013 07:24 PM, Gleb Natapov wrote: > > I agree that this is mostly code style issue and with Takuya patch the > > indentation is dipper. Also the structure of mmu_free_roots() resembles > > mmu_alloc_shadow_roots() currently. The latter has the same if(){return} > > pattern. I also agree with Takuya that locking symmetry can be improved. > > What about something like this (untested): > > It is good to me! ;) > I agree with you two! Thank you for reviewing. Gleb, could you please make it your official patch? Takuya -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html