On 17.04.2013, at 14:06, Paolo Bonzini wrote: > Il 17/04/2013 13:59, Alexander Graf ha scritto: >>>> Well, we just got a patch to make it at least compile, >> That was really just Yang (blindly?) fixing an issue I pointed out on >> ARM. There is no kvm user space support for IA64. The kernel side has >> been KConfig depending on BROKEN for a year already: > > Yes, I know. > > Still, __KVM_HAVE_IRQCHIP is clearly a subset of __KVM_HAVE_IOAPIC; > defining one without the other makes no sense and will cause compilation > or link errors for trace_kvm_ack_irq. > > Either we drop it altogether, or we should not break compilation > consciously---especially if the problem is so trivial and obvious that > you had to think of leaving it out. I disagree. I actually _want_ to break it on purpose, so we have even more reason to remove all that useless code if nobody complains. Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html