Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 17/04/2013 13:59, Alexander Graf ha scritto:
>> > Well, we just got a patch to make it at least compile,
> That was really just Yang (blindly?) fixing an issue I pointed out on
> ARM. There is no kvm user space support for IA64. The kernel side has
> been KConfig depending on BROKEN for a year already:

Yes, I know.

Still, __KVM_HAVE_IRQCHIP is clearly a subset of __KVM_HAVE_IOAPIC;
defining one without the other makes no sense and will cause compilation
or link errors for trace_kvm_ack_irq.

Either we drop it altogether, or we should not break compilation
consciously---especially if the problem is so trivial and obvious that
you had to think of leaving it out.

Paolo

> commit a6bb7929677aacfce3f864c3cdacaa7d527945d5
> Author: Avi Kivity <avi@xxxxxxxxxx>
> Date:   Thu May 17 13:14:08 2012 +0300
> 
>     KVM: ia64: Mark ia64 KVM as BROKEN
> 
>     Practically all patches to ia64 KVM are build fixes; numerous warnings remain;
>     the last patch from the maintainer was committed more than three years ago.  It
>     is clear that no one is using this thing.
> 
>     Mark as BROKEN to ensure people don't get hit by pointless build problems.
> 
>     Signed-off-by: Avi Kivity <avi@xxxxxxxxxx>
>     Signed-off-by: Marcelo Tosatti <mtosatti@xxxxxxxxxx>
>     Signed-off-by: Avi Kivity <avi@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux