On 12 December 2011 17:40, Avi Kivity <avi@xxxxxxxxxx> wrote: > On 12/12/2011 06:31 PM, Peter Maydell wrote: >> I think with an in-kernel GIC model you'd only need to be able to set >> one of the (256 including internal-to-the-CPU inputs) GIC input lines; >> the GIC itself then connects directly to the vcpu IRQ and FIQ. >> >> So we could just have different semantics for the ioctl in the 'kernel >> GIC model enabled' config, as you suggest. > > btw, since we use the KVM_IRQ_LINE ioctl, it may make sense to require > KVM_CREATE_IRQCHIP. To create a kernel GIC model, just call > KVM_CREATE_IRQCHIP with a different parameter. This removes an "except > for ARM" from the documentation. Just to yank this thread back from the dead, Christoffer pointed out that at the moment QEMU only calls KVM_CREATE_IRQCHIP if the user asked for one on the command line. This makes sense to me, since KVM_CREATE_IRQCHIP is saying "create me an in-kernel interrupt controller", and so for ARM it ought to mean "create an in-kernel GIC model"... So I think it would be better just to fix the documentation to note that on some architectures it doesn't make sense to call KVM_IRQ_LINE unless you've previously asked for an in kernel irq chip via KVM_CREATE_IRQCHIP. -- PMM -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
