On 11/21/2011 04:40 PM, Takuya Yoshikawa wrote: > (2011/11/21 17:34), Avi Kivity wrote: >>> Do you have any preference for the arguments ordering? >>> >>> I think placing the target one, memslot in this case, first is >>> conventional in >>> the kernel code, except when we want to place "kvm" or something like >>> that. >>> >>> But in kvm code, there seems to be some difference. >> >> You mean for the macro? Yes, making memslot the first argument is a >> good idea. Any difference in kvm code is not intentional. >> > > Yes. > > Xiao, please change the order if you have no problem. > OK, will change it in the next version, thanks! -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html