Re: [PATCH 5/5 V2] kvm tools: Initialize and use VESA and VNC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/24/2011 03:27 PM, Paolo Bonzini wrote:
On 05/24/2011 01:56 PM, Pekka Enberg wrote:
> If uint64_t is defined differently than u64, you won't be able to pass it by
>  reference if an external library expects it.

Oh, the sizes must be the same for obvious reasons so that shouldn't
be a problem and it's better to do the casting in the external API
calls than in core code.

Be careful about unsigned long vs. unsigned long long.

Yes, that's the issue I had in mind.

If you want to use the u64 spelling that's fine, but I would use a custom header that defines it from uint64_t.

And now you'll have printf/printk format mismatches if they happen to be different.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux