On 05/24/2011 02:38 PM, Pekka Enberg wrote:
Hi Avi, On Tue, May 24, 2011 at 2:30 PM, Avi Kivity<avi@xxxxxxxxxx> wrote: > What happens when you start using userspace libraries? > > Eventually you'll have a lot more of that than kernel code. I don't quite understand what problems you think we might have. We're already using userspace libraries (libvnc) and most of us code is non-kernel code.
If uint64_t is defined differently than u64, you won't be able to pass it by reference if an external library expects it.
We switched to u64 and friends for two reasons: (1) using uint*_t turned out to be painful when using kernel headers (e.g., mptables, e820, etc.) and (2) we want to be as close as possible to the coding style of tools/perf to be able to reuse their code in the future.
Regarding this reuse, I see it's done by copy/paste. Won't it be better to have tools/lib and have tools/perf and tools/kvm use that?
-- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html