Hi Avi, On Tue, May 24, 2011 at 2:41 PM, Avi Kivity <avi@xxxxxxxxxx> wrote: >> I don't quite understand what problems you think we might have. We're >> already using userspace libraries (libvnc) and most of us code is >> non-kernel code. > > If uint64_t is defined differently than u64, you won't be able to pass it by > reference if an external library expects it. Oh, the sizes must be the same for obvious reasons so that shouldn't be a problem and it's better to do the casting in the external API calls than in core code. On Tue, May 24, 2011 at 2:41 PM, Avi Kivity <avi@xxxxxxxxxx> wrote: > Regarding this reuse, I see it's done by copy/paste. Won't it be better to > have tools/lib and have tools/perf and tools/kvm use that? Yes, absolutely. We're keeping things well-contained under tools/kvm with copy-paste until we hit Linus' tree in the future, though, for merge reasons. Pekka -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html