On Mon, May 16, 2011 at 10:44:28AM +0300, Nadav Har'El wrote: > On Mon, May 16, 2011, Gleb Natapov wrote about "Re: [PATCH 0/30] nVMX: Nested VMX, v9": > > > Hi, I can quite easily save this state in a different place which is saved - > > > The easiest will just be to use vmcs12, which has place for exactly the fields > > > we want to save (and they are rewritten anyway when we exit to L1). > > > > > This will not address the problem that the state will not be visible to > > generic logic in x86.c. > > Maybe I misunderstood your intention, but given that vmcs12 is in guest > memory, which is migrated as well, isn't that enough (for the live migration > issue)? > I pointed two issues. Migration was a second and minor one since there is a long why before migration will work with nested guest anyway. The first one was much more important, so let me repeat it again. To move nested event handling into generic code IDT vectoring info has to be parsed into data structure that event injection code in x86.c actually works with. And that code does not manipulate vmx->idt_vectoring_info or SVM analog directly, but it works with event queue instead. SVM does this right and there is nothing I can see that prevents moving SVM logic into x86.c. I don't see how your VMX logic can be moved into x86.c as is since it works on internal VMX fields directly. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
