On 05/05/2011 10:45 PM, Pekka Enberg wrote: > On Thu, 2011-05-05 at 10:22 +0200, Ingo Molnar wrote: >> * Ingo Molnar <mingo@xxxxxxx> wrote: >> >>> * Ingo Molnar <mingo@xxxxxxx> wrote: >>> >>>> I'm not entirely happy about how it has added dependent includes to virtio.c >>>> but that's a property of this messy header file. Might be worth adding a >>>> comment about that. >>> >>> This block: >>> >>>> +#include <linux/stringify.h> >>>> +#include <linux/bitops.h> >>>> +#include <asm/alternative.h> >>>> #include <asm/system.h> >>> >>> Could be put into a new tools/kvm/include/kvm/barrier.h file, with a comment - >>> that way the virtio.c inclusion looks very clean. >>> >>> Note: i'd not put it into linux/barrier.h, to not clash with any possible >>> future linux/barrier.h file, and to also make it clear that this is a kvm >>> specific wrapper. >> >> Like the more complete patch below. Build-tested on 32-bit and 64-bit systems, >> boot tested on a 64-bit box. > > Applied, thanks Ingo! Asias, please let me know if master doesn't build > for you still. Works for me now. -- Best Regards, Asias He -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
