* Ingo Molnar <mingo@xxxxxxx> wrote: > I'm not entirely happy about how it has added dependent includes to virtio.c > but that's a property of this messy header file. Might be worth adding a > comment about that. This block: > +#include <linux/stringify.h> > +#include <linux/bitops.h> > +#include <asm/alternative.h> > #include <asm/system.h> Could be put into a new tools/kvm/include/kvm/barrier.h file, with a comment - that way the virtio.c inclusion looks very clean. Note: i'd not put it into linux/barrier.h, to not clash with any possible future linux/barrier.h file, and to also make it clear that this is a kvm specific wrapper. Oh, and those 3 lines could be put into upstream arch/x86's system.h as well, to make asm/system.h standalone includable. Does anyone want to send a patch for that? Once that header fix is upstream and once tools/kvm/ merges that upstream kernel the special wrapper barrier.h can be dropped and virtio.c can include asm/system.h for the barriers. The joys of a clean Git workflow and a unified kernel+tools tree, it actually helps fix crap on both sides :-) Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
